Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featrue: Add initializeFrom encoders and decoders #226

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Featrue: Add initializeFrom encoders and decoders #226

merged 5 commits into from
Jul 26, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jun 19, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-512

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas marked this pull request as draft June 19, 2023 13:33
@josemarinas josemarinas force-pushed the f/OS-512-ensure-daos-and-plugins-can-be-upgraded branch 2 times, most recently from 1fc695f to 3c2bf57 Compare July 11, 2023 09:43
@josemarinas josemarinas force-pushed the f/OS-512-ensure-daos-and-plugins-can-be-upgraded branch from 3c2bf57 to d3fdf4e Compare July 19, 2023 15:09
@josemarinas josemarinas marked this pull request as ready for review July 19, 2023 15:10
heueristik
heueristik suggested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a plugin update as an example for when initializeFrom is used

modules/client/examples/01-client/01-create-dao.ts Show resolved Hide resolved
modules/client/examples/05-encoders-decoders/14-initialize-from.ts Outdated Show resolved Hide resolved
heueristik
heueristik previously approved these changes Jul 26, 2023
View reviewed changes
@josemarinas josemarinas force-pushed the f/OS-512-ensure-daos-and-plugins-can-be-upgraded branch from a340208 to 7b0584a Compare July 26, 2023 12:56
heueristik
heueristik previously approved these changes Jul 26, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josemarinas josemarinas merged commit f29d8de into develop Jul 26, 2023
7 checks passed
@josemarinas josemarinas deleted the f/OS-512-ensure-daos-and-plugins-can-be-upgraded branch July 26, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@brickpop brickpop Awaiting requested review from brickpop

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarinas @heueristik